Completions for Deref Coercions #458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jonesey13
force-pushed
the
deref
branch
6 times, most recently
from
43cdd97 to
771b78d
Compare
phildawes
added a commit
that referenced
this pull request
Jan 2, 2016
Completions for Deref Coercions
|
Oh nice! Thanks v much @Jonesey13 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes Issue #455 by recursively completing on coerced types (see the new tests for examples).
Since this also retroactively solves issue #438 I've removed the changes from my earlier commit #439 as it is now redundant.
N.B. For the tests I had to copy over the definition of the Deref trait since it appears that travis.ci cannot find the source code for crate std.