-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(ruff): add extra linting rules: isort, pyupgrade, numpy, ruff-specific #243
Conversation
I don't think you can use the | syntax instead on Union until 3.10. |
Good catch. This PR will probably look pretty messy until I nail down exactly which rules to use. |
ff0d3ed
to
05f0ded
Compare
Actually, in hindsight this is exactly what |
|
8e0ac2f
to
b0c7511
Compare
b0c7511
to
78903bd
Compare
78903bd
to
922b3c8
Compare
@ketiltrout @jrs65 I've done another run through to make sure everything is working as expected here, so I want to ping you both for review again. |
These additions are useful for improving overall quality and consistency of code and eliminating extra things for PR reviewers to check. The ruff python version is set to python 3.8, since this is the minimum supported version.
except
statementsAdditional ignored rules:
I'm happy to add more rules if there's anything else of interest