Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce linting rule RUF012 #258

Merged
merged 4 commits into from
May 1, 2024
Merged

Enforce linting rule RUF012 #258

merged 4 commits into from
May 1, 2024

Conversation

ljgray
Copy link
Contributor

@ljgray ljgray commented Jan 17, 2024

See PEP 526. Mutable class attributes should be annotated with typing.ClassVar. I think that this makes sense in the cases I've implemented it, but I'm open to arguments.

Also, remove Sphinx < 5 version pin and set sphinx language to English

@ljgray ljgray marked this pull request as ready for review January 17, 2024 01:21
@ljgray ljgray requested review from jrs65 and ketiltrout January 17, 2024 01:21
@ljgray ljgray force-pushed the ljg/ruff-update branch from 9859bfb to 3e0d487 Compare May 1, 2024 18:58
@ljgray ljgray force-pushed the ljg/ruff-update branch from 3e0d487 to e1c19b5 Compare May 1, 2024 18:59
@ljgray ljgray requested a review from rikvl May 1, 2024 20:00
Copy link
Member

@ketiltrout ketiltrout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine.

@ljgray ljgray merged commit 3a059dc into master May 1, 2024
4 checks passed
@ljgray ljgray deleted the ljg/ruff-update branch May 1, 2024 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants