-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(flagging): mask rfi based on delay filtered visibilities #268
Conversation
Adds three new tasks: - analysis.dayenu.DayenuDelayFilterFixedCutoff enables delay filtering of timeseries with rapidly changing frequency masks. - analysis.transform.ReduceChisq calculates a chi2-per-dof test statistic by comparing the delay filtered visibilities to the inverse noise variance stored in the weights. - analysis.flagging.RFIMaskChisqHighDelay generates a mask from this chi2-per-dof test statistic.
Depends on #265 for the arPLS method. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me - just some minor comments
Make DayenuDelayFilterFixedCutoff a subclass of transform.ReduceChisq. If reduce_baseline option is set to True, then this task will calculate the chi-squared-per-dof test statistic in place in order to reduce memory usage. Also add option to this task to mask short baselines.
Excludes horizon plus 100 nsec leakage due to the primary beam for all baselines.
I've confirmed that using the updated |
Sounds good to me |
Adds three new tasks: