Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(flagging): mask rfi based on delay filtered visibilities #268

Merged
merged 8 commits into from
May 22, 2024

Conversation

ssiegelx
Copy link
Contributor

Adds three new tasks:

  • analysis.dayenu.DayenuDelayFilterFixedCutoff enables delay filtering of timeseries with rapidly changing frequency masks.
  • analysis.transform.ReduceChisq calculates a chi2-per-dof test statistic by comparing the delay filtered visibilities to the inverse noise variance stored in the weights.
  • analysis.flagging.RFIMaskChisqHighDelay generates a mask from this chi2-per-dof test statistic.

Adds three new tasks:
 - analysis.dayenu.DayenuDelayFilterFixedCutoff enables
   delay filtering of timeseries with rapidly changing frequency masks.
 - analysis.transform.ReduceChisq calculates a chi2-per-dof test
   statistic by comparing the delay filtered visibilities to the
   inverse noise variance stored in the weights.
 - analysis.flagging.RFIMaskChisqHighDelay generates a mask from this
   chi2-per-dof test statistic.
@ssiegelx ssiegelx requested a review from ljgray May 14, 2024 18:31
@ssiegelx
Copy link
Contributor Author

Depends on #265 for the arPLS method.

Copy link
Contributor

@ljgray ljgray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - just some minor comments

draco/analysis/dayenu.py Outdated Show resolved Hide resolved
draco/analysis/dayenu.py Outdated Show resolved Hide resolved
draco/analysis/flagging.py Outdated Show resolved Hide resolved
Seth Siegel and others added 5 commits May 14, 2024 13:45
Make DayenuDelayFilterFixedCutoff a subclass of transform.ReduceChisq.
If reduce_baseline option is set to True, then this task will calculate
the chi-squared-per-dof test statistic in place in order to reduce
memory usage.  Also add option to this task to mask short baselines.
Excludes horizon plus 100 nsec leakage due to the
primary beam for all baselines.
@ssiegelx
Copy link
Contributor Author

I've confirmed that using the updated DayenuDelayFilterFixedCutoff task yields the same result as previously obtained using the three separate tasks. If there are no objections I will go ahead and merge this PR and the corresponding one in ch_pipeline.

@ljgray
Copy link
Contributor

ljgray commented May 22, 2024

I've confirmed that using the updated DayenuDelayFilterFixedCutoff task yields the same result as previously obtained using the three separate tasks. If there are no objections I will go ahead and merge this PR and the corresponding one in ch_pipeline.

Sounds good to me

@ssiegelx ssiegelx merged commit 8b0f76b into master May 22, 2024
4 checks passed
@ssiegelx ssiegelx deleted the ss/rfi_delay_filter branch May 22, 2024 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants