-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Baseline-dependent rebinner #269
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljgray
force-pushed
the
lg/multi-baseline-rebinner
branch
from
May 15, 2024 21:34
a255612
to
61ea69b
Compare
ssiegelx
requested changes
May 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great and simplifies things considerably compared to the baseline-independent weighting. I just have a few comments.
ljgray
force-pushed
the
lg/multi-baseline-rebinner
branch
6 times, most recently
from
May 22, 2024 19:03
ecda38d
to
a5826f9
Compare
ljgray
force-pushed
the
lg/multi-baseline-rebinner
branch
3 times, most recently
from
May 22, 2024 21:34
2acb3bb
to
4dcfa25
Compare
14 tasks
ljgray
force-pushed
the
lg/multi-baseline-rebinner
branch
2 times, most recently
from
May 24, 2024 18:33
26cd861
to
e9cb12f
Compare
ssiegelx
approved these changes
May 24, 2024
ssiegelx
reviewed
May 24, 2024
ljgray
force-pushed
the
lg/multi-baseline-rebinner
branch
from
May 24, 2024 21:59
e9cb12f
to
d54e3b2
Compare
ljgray
force-pushed
the
lg/multi-baseline-rebinner
branch
from
May 24, 2024 23:04
d54e3b2
to
f800c5a
Compare
ssiegelx
approved these changes
May 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implements a rebinning task similar to #266. This updated version uses the actual per-baseline weights, rather than a mean, and avoids creating a separate
rebin_weight
dataset entirely. This should provide marginally better rebinning behaviour in the presence of bad baselines, and does not require complicated tracking of multiple datasets throughout various pipelines.It also implements a baseline-dependent
effective_ra
dataset and a simplifiedeffective_ra
centring correction.From testing, this seems to show a light reduction in noise across all delays compared to the mean-weighted rebinning.
Notes
stack
axis in theeffective_ra
dataset means that containers produced by the old rebinner cannot be loaded with this PRThis PR will replace #266 and would close chime-experiment/ch_pipeline#242 as it is no longer needed.
Depends on radiocosmology/caput#239 and #231 for updates to container copying behaviour.I've decided to implement this in a future PR