limit rplot to heatmap! for now #573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #573 +/- ##
=======================================
Coverage 80.56% 80.56%
=======================================
Files 57 57
Lines 4163 4163
=======================================
Hits 3354 3354
Misses 809 809 ☔ View full report in Codecov by Sentry. |
|
ah yeah with the new SpecAPI we should probably rework all this anyway... On the bright side, we will hopefully not need that horrible |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR drops the
plottypekeyword and limits plots toheatmap!because its all I use and the current method breaks in Makie 0.20@asinghvi17 if you understand why this broke we could keep the functionality and fix it instead, but I don't!