Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip missingval when calling extract with skipmissing = true #617

Merged
merged 2 commits into from
Mar 27, 2024

Conversation

tiemvanderdeure
Copy link
Collaborator

Currently only values equal to missing are skipped. This PR makes it so that values equal to the missingval of the input raster are skipped as well.

Copy link

codecov bot commented Mar 26, 2024

Codecov Report

Attention: Patch coverage is 90.90909% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 81.37%. Comparing base (7ab31df) to head (0aa3b60).
Report is 1 commits behind head on main.

Files Patch % Lines
src/methods/extract.jl 90.90% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #617      +/-   ##
==========================================
+ Coverage   81.34%   81.37%   +0.02%     
==========================================
  Files          61       61              
  Lines        4337     4343       +6     
==========================================
+ Hits         3528     3534       +6     
  Misses        809      809              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rafaqz rafaqz merged commit 81f9672 into rafaqz:main Mar 27, 2024
4 of 5 checks passed
@tiemvanderdeure tiemvanderdeure deleted the extract_skipmissing branch April 8, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants