Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mooc.fi logo in nav bar and footer #1353

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Redande
Copy link
Contributor

@Redande Redande commented Dec 9, 2024

Summary by CodeRabbit

  • Style
    • Updated the footer to display refreshed branding with improved logo positioning.
    • Enhanced the navigation display by adjusting the logo image and refining its color styling for a cleaner, more consistent look.

Copy link
Contributor

coderabbitai bot commented Dec 9, 2024

Walkthrough

The pull request updates two UI components within the shared module. In the Footer component, the MOOCfi logo import has been switched from moocfiLogo.svg to moocfiTextLogo.svg and an inline style align-items: center; has been added to the logo container. In the SimpleNav component, the logo import has been changed from moocfiLogoNoText.svg to moocfiLogo.svg, and the CSS styling has been modified to use the color property instead of fill for the logo’s SVG element.

Changes

File(s) Change Summary
shared-module/.../Footer.tsx Updated logo import to moocfiTextLogo.svg and added align-items: center; to the inline styles for centering the logos in the flex container.
shared-module/.../NavBar/SimpleNav.tsx Updated logo import to moocfiLogo.svg and replaced the CSS fill property with the color property in the styled SVG icon.

Suggested labels

course-material

Suggested reviewers

  • nygrenh

Poem

I'm a rabbit with code in my stride,
Hopping through changes with a bright-eyed guide,
Logos now transformed with styles aligned just right,
Each update sings under the moonlit night,
For every tweak, my heart leaps in pure delight!


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 09384e8 and 6c3a287.

⛔ Files ignored due to path filters (26)
  • shared-module/packages/common/src/img/moocfiLogo.svg is excluded by !**/*.svg
  • shared-module/packages/common/src/img/moocfiTextLogo.svg is excluded by !**/*.svg
  • system-tests/src/__screenshots__/author.spec.ts/author-block-desktop-regular.png is excluded by !**/*.png
  • system-tests/src/__screenshots__/author.spec.ts/author-block-mobile-tall.png is excluded by !**/*.png
  • system-tests/src/__screenshots__/automatic-completion.spec.ts/automatic-completion-registration-page-desktop-regular.png is excluded by !**/*.png
  • system-tests/src/__screenshots__/automatic-completion.spec.ts/automatic-completion-registration-page-mobile-tall.png is excluded by !**/*.png
  • system-tests/src/__screenshots__/certificates/configure-certificate.test.ts/management-page-desktop-regular.png is excluded by !**/*.png
  • system-tests/src/__screenshots__/certificates/configure-certificate.test.ts/management-page-mobile-tall.png is excluded by !**/*.png
  • system-tests/src/__screenshots__/certificates/generate-certificate.test.ts/generated-certificate-desktop-regular.png is excluded by !**/*.png
  • system-tests/src/__screenshots__/certificates/generate-certificate.test.ts/generated-certificate-mobile-tall.png is excluded by !**/*.png
  • system-tests/src/__screenshots__/change-course-language.spec.ts/course-lang-selection-eng-to-fi-desktop-regular.png is excluded by !**/*.png
  • system-tests/src/__screenshots__/change-course-language.spec.ts/course-lang-selection-eng-to-fi-mobile-tall.png is excluded by !**/*.png
  • system-tests/src/__screenshots__/change-course-language.spec.ts/course-lang-selection-fi-to-eng-desktop-regular.png is excluded by !**/*.png
  • system-tests/src/__screenshots__/change-course-language.spec.ts/course-lang-selection-fi-to-eng-mobile-tall.png is excluded by !**/*.png
  • system-tests/src/__screenshots__/content-search.spec.ts/search-content-with-two-words-not-just-after-each-other-desktop-regular.png is excluded by !**/*.png
  • system-tests/src/__screenshots__/content-search.spec.ts/search-content-with-two-words-not-just-after-each-other-mobile-tall.png is excluded by !**/*.png
  • system-tests/src/__screenshots__/content-search.spec.ts/search-continuous-phrases-ranked-higher-than-word-matches-desktop-regular.png is excluded by !**/*.png
  • system-tests/src/__screenshots__/content-search.spec.ts/search-continuous-phrases-ranked-higher-than-word-matches-mobile-tall.png is excluded by !**/*.png
  • system-tests/src/__screenshots__/course-instance-management/course-instance-management.spec.ts/course-management-page-after-delete-desktop-regular.png is excluded by !**/*.png
  • system-tests/src/__screenshots__/course-instance-management/course-instance-management.spec.ts/course-management-page-after-delete-mobile-tall.png is excluded by !**/*.png
  • system-tests/src/__screenshots__/course-instance-management/course-instance-management.spec.ts/course-management-page-with-new-instance-desktop-regular.png is excluded by !**/*.png
  • system-tests/src/__screenshots__/course-instance-management/course-instance-management.spec.ts/course-management-page-with-new-instance-mobile-tall.png is excluded by !**/*.png
  • system-tests/src/__screenshots__/course-instance-management/course-instance-management.spec.ts/initial-course-management-page-desktop-regular.png is excluded by !**/*.png
  • system-tests/src/__screenshots__/course-instance-management/course-instance-management.spec.ts/initial-course-management-page-mobile-tall.png is excluded by !**/*.png
  • system-tests/src/__screenshots__/course-instance-management/course-instance-management.spec.ts/initial-management-page-desktop-regular.png is excluded by !**/*.png
  • system-tests/src/__screenshots__/course-instance-management/course-instance-management.spec.ts/initial-management-page-editing-desktop-regular.png is excluded by !**/*.png
📒 Files selected for processing (2)
  • shared-module/packages/common/src/components/Footer.tsx (2 hunks)
  • shared-module/packages/common/src/components/Navigation/NavBar/SimpleNav.tsx (2 hunks)
🚧 Files skipped from review as they are similar to previous changes (2)
  • shared-module/packages/common/src/components/Navigation/NavBar/SimpleNav.tsx
  • shared-module/packages/common/src/components/Footer.tsx
⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: headless_lms
  • GitHub Check: build
  • GitHub Check: build-and-deploy

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@Redande
Copy link
Contributor Author

Redande commented Dec 9, 2024

TODO: fix mobile view, currently new wide logo makes hamburger menu overflow off screen

@Redande Redande force-pushed the update-moocfi-logo branch from 7d0cc59 to 5d7aaa5 Compare February 5, 2025 20:03
@Redande Redande marked this pull request as ready for review February 13, 2025 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant