-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ar786 patch 1 #47
Ar786 patch 1 #47
Conversation
So one question. Why have you done more than what the issue asked you to do? Plus, it looks like you've removed the C testfiles. The execute_py.pi need not be a separate file. You could possibly add that logic to the code execution function in cleaner.py |
okay |
are these fine ? |
Cannot accept this PR. Everyone else's commit history will get erased. Plus 26 commits are too much. Also, I told you to work on just the initialise logic right? Please do send a new PR that contains only that logic in sudocode_pi.py and any other changes required in other files. Sorry! |
@rahulkumaran bhaiya but last time you told just to bring back changes for readme and testfiles. |
I know you've worked hard but this is not about me or you. It's about the project. I don't really want to add such a huge change at once so I'm definitely not adding the whole thing @AR786. That's why I've constantly been telling everyone to read the issues carefully. Anyway, all these features will have to be implemented slowly, one after the other. So I could probably assign you to a couple directly. That's the maximum I can do. Also, if you read my previous comment it's evident that I want you to get the logic only initialise. Really sorry, but I can't really do much about this. The max I'll do is assign you directly to half of the python related issues. Does that sound okay with you? |
Okay bhaiya.. i will do just what you say. |
This request is for the issue #19