Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added command line argument for csv / json. csv is default #9

Merged
merged 15 commits into from
Dec 15, 2024
Merged

added command line argument for csv / json. csv is default #9

merged 15 commits into from
Dec 15, 2024

Conversation

joshkenney
Copy link
Contributor

No description provided.

@joshkenney joshkenney closed this Nov 27, 2024
@joshkenney joshkenney reopened this Nov 27, 2024
raleighlittles
raleighlittles reviewed Nov 27, 2024
View reviewed changes
Cargo.toml Outdated Show resolved Hide resolved
raleighlittles
raleighlittles reviewed Nov 27, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
@raleighlittles raleighlittles added the enhancement New feature or request label Nov 27, 2024
@joshkenney
Copy link
Contributor Author

joshkenney commented Nov 27, 2024 •
edited
Loading

@raleighlittles thanks - deleted upper level Config.toml and Cargo.lock

re: README
i need to use this path

$ cd iTunesDB-Parser
$ ./parser/target/debug/itunesdb_parser <path-to-itunesdb-file> '<type>'

as written yours does nothing

➜  itunes-db-parser git:(main) ✗ target/debug/itunesdb_parser ~/Downloads/GEOFFREY/iPod_Control/iTunes/iTunesDB "itunes" 
zsh: no such file or directory: target/debug/itunesdb_parser

raleighlittles
raleighlittles reviewed Nov 27, 2024
View reviewed changes
src/main.rs Outdated Show resolved Hide resolved
@raleighlittles
Copy link
Owner

Can you post a JSON file that your branch creates? Run the parser on one of the sample itunesDB files - let me know which. Also post a CSV output from the same iTunesDB file so I can compare it against dev. If it matches I would be ready to merge you. @joshkenney

@joshkenney
Copy link
Contributor Author

@raleighlittles done!
./parser/target/debug/itunesdb_parser ./sample-files/2023-06-26_iTunesDB-1 itunes csv
./parser/target/debug/itunesdb_parser ./sample-files/2023-06-26_iTunesDB-1 itunes json
music.json
music.csv

@joshkenney
improved create_playlist_from_tracks() to batch 100 songs
558efb2 
this respects the limit set by Spotify API andallows for the sumbissions of playlists greater than 100 songs
@joshkenney
improved create_playlist_from_tracks() to batch 100 songs
5d33e72 
this respects the limit set by Spotify API andallows for the sumbissions of playlists greater than 100 songs
@raleighlittles
Copy link
Owner

Looks good to me.

@raleighlittles raleighlittles merged commit e143cf8 into raleighlittles:main Dec 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raleighlittles raleighlittles raleighlittles left review comments

Assignees

@joshkenney joshkenney

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joshkenney @raleighlittles