Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the suffix _type for the C structures in GLS #362

Merged
merged 1 commit into from
Jan 3, 2025
Merged

Conversation

amontoison
Copy link
Member

@nimgould Is it fine for you?
It doesn't concern the code in Fortran, it's just the structures in the C interface that are renamed.
I always need some sed commands in the Julia interface because of this missing suffix.
Only GLS is concerned by this "issue".

@amontoison amontoison changed the title Use the suffix _type for the C structures in GLS Add the suffix _type for the C structures in GLS Jan 2, 2025
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.84%. Comparing base (a4377f1) to head (32cb121).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #362   +/-   ##
=======================================
  Coverage   41.84%   41.84%           
=======================================
  Files         325      325           
  Lines      167628   167628           
  Branches    58076    58076           
=======================================
  Hits        70143    70143           
  Misses      79992    79992           
  Partials    17493    17493           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nimgould nimgould merged commit f91baf5 into master Jan 3, 2025
13 checks passed
@nimgould
Copy link
Contributor

nimgould commented Jan 3, 2025

I am not completely happy with this as it is breaking change for any C user who already uses the gls package. Of course, this may be nobody! OK, let's do it, and I'll divert any grumbles to you :)

@amontoison amontoison deleted the gls_structures branch January 3, 2025 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants