Issues when using compounded=False #404
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Error occurring when compounded = False due to line 567. Series is input into html() function in quantstats/reports.py and .apply(_df.sum) throws and error due to type mismatch. Can allternatively also convert series to DataFrame however would be done elsewhere.
|
in plots() when mode.lower == "full" most of the function calls from _plots do not have the compounded argument. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When analysing returns of strategies instead of the whole portfolio it is useful not to compound the returns as we want trades at all periods to be weighted the same. When compound = False the plots arising from the quantstats.reports.full() function did not have compounded argument included. The same error was in basic().
When running qs.reports.html() an error in qs.reports._plotting.wrappers.yearly_returns() arose due to the assumption that returns would be a DataFrame. You can either use a fix similar to fine or convert all Series into DataFrame like you have in other sections.