Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev-v2.11] rancher-alerting-drivers 106.0.0-rc.1 update #5073

Open
wants to merge 4 commits into
base: dev-v2.11
Choose a base branch
from

Conversation

alexandreLamarre
Copy link
Contributor

@alexandreLamarre alexandreLamarre commented Feb 3, 2025

Related issue : rancher/rancher#48831

Pull Requests Rules

  • Never remove an already released chart!

    • This does not apply to RC's because they are not released.
  • Each Pull Request should only modify one chart with its dependencies.

  • Pull request title:

    [dev-v2.X] <chart> <version> <action>
    
    • <action>: 1 of (bump; remove; UnRC)

Checkpoints for Chart Bumps

release.yaml:

  • Each chart version in release.yaml DOES NOT modify an already released chart. If so, stop and modify the versions so that it releases a net-new chart.
  • Each chart version in release.yaml IS exactly 1 more patch or minor version than the last released chart version. If not, stop and modify the versions so that it releases a net-new chart.

Chart.yaml and index.yaml:

  • The index.yaml file has an entry for your new chart version.
  • The index.yaml entries for each chart matches the Chart.yaml for each chart.
  • Each chart has ALL required annotations
    • kube-version annotation
    • rancher-version annotation
    • permits-os annotation (indicates Windows and/or Linux)

Fill the following only if required by your manager.

Issue:
Solution
QA Testing Considerations

Copy link

github-actions bot commented Feb 3, 2025

Validation steps

  • Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.
  Ex:-
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913
  
  • Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
  • Approve the PR to run the CI check.

@alexandreLamarre alexandreLamarre changed the base branch from dev-v2.10 to dev-v2.11 February 3, 2025 16:04
@alexandreLamarre alexandreLamarre marked this pull request as ready for review February 3, 2025 16:04
@alexandreLamarre alexandreLamarre requested a review from a team as a code owner February 3, 2025 16:04
annotations:
catalog.cattle.io/certified: rancher
catalog.cattle.io/display-name: Alerting Drivers
catalog.cattle.io/kube-version: '>= 1.28.0-0 < 1.32.0-0'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we could use this PR to also bump the kube-version and rancher-version annotations to fit the requirements for 2.11 closing rancher/rancher#48831

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, but requires some sanity testing, will update in a sec

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming rancher-version wasn't updated to allow testing with rancher 2.10, is that right? I don't have a problem with that, just want to make sure I understood the thought process for not including it in this PR ;)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah no good catch it just slipped my mind

Copy link

github-actions bot commented Feb 3, 2025

Validation steps

  • Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.
  Ex:-
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913
  
  • Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
  • Approve the PR to run the CI check.

Signed-off-by: Alexandre Lamarre <[email protected]>

bump rancher support to 2.11

Signed-off-by: Alexandre Lamarre <[email protected]>
Signed-off-by: Alexandre Lamarre <[email protected]>
Signed-off-by: Alexandre Lamarre <[email protected]>
Signed-off-by: Alexandre Lamarre <[email protected]>
Copy link

github-actions bot commented Feb 3, 2025

Validation steps

  • Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.
  Ex:-
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913
  
  • Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
  • Approve the PR to run the CI check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants