Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backport v2.9.x] Allow users to easily see expiring harvester cloud credentials and to renew them #11270

Closed
Tracked by #11256
richard-cox opened this issue Jun 20, 2024 · 9 comments
Assignees
Labels
kind/enhancement priority/0 QA/manual-test Indicates issue requires manually testing release-note size/2 Size Estimate 2
Milestone

Comments

@richard-cox
Copy link
Member

richard-cox commented Jun 20, 2024

Epic: #11256 SURE-8516

Requires expiring label on cloud cred

  • Global notification somewhere warning of expired / soon to expire harv cloud creds
  • Clearly see in cloud cred table expired / soon to expire (see cluster dashboard certs list for pattern?)
    • Column for sorting, only if harv cloud cred present?
  • Sub row in harv clusters list to warn that cluster has a cloud cred that's expiring
  • Cloud Cred bulk action to renew (recreate kubeconfig, update cloud cred)

Edit: Blocked on rancher/rancher#47243

@richard-cox richard-cox added kind/enhancement QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this priority/0 labels Jun 20, 2024
@richard-cox richard-cox added this to the v2.9.next1 milestone Jun 20, 2024
@richard-cox
Copy link
Member Author

/forwardport v2.10.0

@gaktive
Copy link
Member

gaktive commented Jul 16, 2024

Making this the backport of #11332 -- we should fix this in 2.10.0 first before backporting to 2.9.1

@gaktive
Copy link
Member

gaktive commented Jul 16, 2024

This needs to line up with Harvester 1.4.0 which is set to come out before 2.10.0.

@gaktive gaktive modified the milestones: v2.9.0, v2.9.next1 Jul 16, 2024
@gaktive gaktive modified the milestones: v2.9.next1, v2.9.next2 Jul 31, 2024
@gaktive gaktive changed the title Allow users to easily see expiring harvester cloud credentials and to renew them [backport v2.9.x] Allow users to easily see expiring harvester cloud credentials and to renew them Jul 31, 2024
@gaktive gaktive added the size/2 Size Estimate 2 label Jul 31, 2024
@gaktive gaktive removed this from the v2.9.next1 milestone Sep 3, 2024
@gaktive gaktive added this to the v2.9.next2 milestone Sep 3, 2024
@gaktive
Copy link
Member

gaktive commented Sep 3, 2024

Pushing out of the September releases but this has to get in for October.

@richard-cox what is this blocked on again? The parent epic points in a few ways so it's not easily clear.

@richard-cox
Copy link
Member Author

richard-cox commented Sep 4, 2024

This is blocked on the approved RFC 010 Harvester Node Driver Credentials. I couldn't directly link that to a gh issue or PR, or JIRA though. @jakefhyde can you confirm the RFC functionality will come in via SURE-8516 / rancher/rancher#44912?

@gaktive
Copy link
Member

gaktive commented Sep 24, 2024

RFC 010 approved but 44912 is now unassigned and off the Hostbusters board. Checking which r/r team can take care of this.

@richard-cox
Copy link
Member Author

richard-cox commented Oct 11, 2024

Release note suggestion

In the Cloud Credential list users can now easily see if a Harvester Credential is about to or has expired and opt to Renew it. The Cluster Management Clusters list will also notify when an associated Harvester Cloud Credential is about to or has expired.

Edit: @LucasSaintarbor Can we update the above to...?

In the Cloud Credential list users can now easily see if a Harvester Credential is about to or has expired and opt to Renew it. The Cluster Management Clusters list will also notify when an associated Harvester Cloud Credential is about to or has expired.

On upgrade existing expired Harvester Credential will not contain a warning. Users can though still Renew their token via the resource's menu.

@irishgordo
Copy link

@richard-cox thanks for this addition 😄 👍 -> I'm going to go ahead and close this out as this has already been validated in:

cc: @khushboo-rancher @bk201

@LucasSaintarbor
Copy link

Release note suggestion

In the Cloud Credential list users can now easily see if a Harvester Credential is about to or has expired and opt to Renew it. The Cluster Management Clusters list will also notify when an associated Harvester Cloud Credential is about to or has expired.

Edit: @LucasSaintarbor Can we update the above to...?

In the Cloud Credential list users can now easily see if a Harvester Credential is about to or has expired and opt to Renew it. The Cluster Management Clusters list will also notify when an associated Harvester Cloud Credential is about to or has expired.

On upgrade existing expired Harvester Credential will not contain a warning. Users can though still Renew their token via the resource's menu.

@richard-cox Thanks for the feedback. I made an update to the RNs here: 1aa6002. Does this work? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement priority/0 QA/manual-test Indicates issue requires manually testing release-note size/2 Size Estimate 2
Projects
None yet
Development

No branches or pull requests

5 participants