Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to easily see expiring harvester cloud credentials and to renew them #11332

Closed
Tracked by #11256
github-actions bot opened this issue Jul 2, 2024 · 11 comments · Fixed by #12157
Closed
Tracked by #11256

Allow users to easily see expiring harvester cloud credentials and to renew them #11332

github-actions bot opened this issue Jul 2, 2024 · 11 comments · Fixed by #12157
Assignees
Labels
Milestone

Comments

@github-actions
Copy link
Contributor

github-actions bot commented Jul 2, 2024

Epic: #11256 SURE-8516

This is a forwardport issue for #11270, automatically created via GitHub Actions workflow initiated by @richard-cox

Original issue body:

Requires expiring label on cloud cred

  • Global notification somewhere warning of expired / soon to expire harv cloud creds
  • Clearly see in cloud cred table expired / soon to expire (see cluster dashboard certs list for pattern?)
    • Column for sorting, only if harv cloud cred present?
  • Sub row in harv clusters list to warn that cluster has a cloud cred that's expiring
  • Cloud Cred bulk action to renew (recreate kubeconfig, update cloud cred)

Edit: Blocked on rancher/rancher#47241

@github-actions github-actions bot added kind/enhancement priority/0 QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this QA/None labels Jul 2, 2024
@github-actions github-actions bot added this to the v2.10.0 milestone Jul 2, 2024
@nwmac nwmac modified the milestones: v2.10.0, v2.11.0 Jul 4, 2024
@gaktive gaktive modified the milestones: v2.11.0, v2.10.0 Jul 4, 2024
@gaktive
Copy link
Member

gaktive commented Jul 16, 2024

Leaving this as the 2.10.0 version since this was the forward port. Making the other one the backport but I'll emphasize that this ticket should be worked on first.

@gaktive
Copy link
Member

gaktive commented Jul 16, 2024

This needs to line up with Harvester 1.4.0 which is set to come out before 2.10.0.

@gaktive gaktive changed the title [forwardport v2.10.0] Allow users to easily see expiring harvester cloud credentials and to renew them Allow users to easily see expiring harvester cloud credentials and to renew them Jul 31, 2024
@gaktive gaktive added size/5 Size Estimate 5 and removed QA/None labels Jul 31, 2024
@richard-cox
Copy link
Member

@richard-cox
Copy link
Member

Release note suggestion

In the Cloud Credential list users can now easily see if a Harvester Credential is about to or has expired and opt to Renew it. The Cluster Management Clusters list will also notify when an associated Harvester Cloud Credential is about to or has expired.

@yonasberhe23
Copy link
Contributor

I do not see automation in the attached PR. moving to To Test for manual validation

@yonasberhe23 yonasberhe23 added QA/manual-test Indicates issue requires manually testing and removed QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this labels Oct 24, 2024
@yonasberhe23
Copy link
Contributor

@irishgordo would you mind taking this as you validated it for 2.9.3?

@khushboo-rancher
Copy link

@yonasberhe23 What is the timeline to close this, Harvester team is occupied with 1.4.0 release till Nov 7?

@richard-cox
Copy link
Member

@khushboo-rancher this is part of the harvester token expiration feature, it's 2.9 counterpart is #11270 which was handled by @irishgordo. It might be best tackling once #12351 has merged as well (currently in review)

@m-ildefons
Copy link
Contributor

I've validated that rancher/rancher#47667 has been fixed in v2.10.0-alpha7
I think this issue can be considered done?

@richard-cox
Copy link
Member

thanks @m-ildefons , i'd be happy to close, @yonasberhe23 are you good too?

@izaac
Copy link
Contributor

izaac commented Nov 11, 2024

@richard-cox I've checked the test executed on rancher/rancher#47667 (comment) And it looks the coverage is good to validate the expectation of this issue. Moving to done.

@izaac izaac closed this as completed Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
7 participants