automation: services - external name tests #13152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yonasberhe23
force-pushed
the
services_tests_e2e
branch
4 times, most recently
from
bde4b16 to
efa6db7
Compare
yonasberhe23
force-pushed
the
services_tests_e2e
branch
3 times, most recently
from
9cda750 to
e892ba2
Compare
yonasberhe23
force-pushed
the
services_tests_e2e
branch
2 times, most recently
from
61d53af to
cfab139
Compare
|
@a-arias could you take a look at this too? 👍🏽 |
|
@yonasberhe23 Will this only cover external names ? In that case the task can be break down to smaller ones for Other than that it looks good to me. |
izaac
added
the
QA/dev-automation
a-arias
previously approved these changes
Jan 24, 2025
@izaac ah good point. i can create some sub task tickets for those other areas |
yonasberhe23
force-pushed
the
services_tests_e2e
branch
2 times, most recently
from
1d5525c to
2a21acf
Compare
yonasberhe23
changed the title
yonasberhe23
force-pushed
the
services_tests_e2e
branch
from
2a21acf to
d1fa5e3
Compare
yonasberhe23
force-pushed
the
services_tests_e2e
branch
from
d1fa5e3 to
e0c0216
Compare
izaac
requested changes
Jan 31, 2025
| @@ -17,6 +17,10 @@ export default class TabbedPo extends ComponentPo { | |||
| return this.self().get('[data-testid="tabbed-block"] > li'); | |||
| } | |||
|
|
|||
| checkSelectedTab(selector: string) { | |||
There was a problem hiding this comment.
I think the method name should include what's being checked here or move the chai assertion to the spec
There was a problem hiding this comment.
ah that isn't very clear. how about assertTabIsActive?
yonasberhe23
force-pushed
the
services_tests_e2e
branch
from
e0c0216 to
23ba8dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #rancher/qa-tasks#1581
This PR also includes small fixes to address flaky Extensions tests.
Checklist