-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for known hosts on ssh secret in Fleet Git Repo #13168
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Francesco Torchia <[email protected]>
Signed-off-by: Francesco Torchia <[email protected]>
@nwmac I cleaned-up the code and added Codemirror and some layout improvements. |
@torchiaf as you prefer, if you want to close this one we can apply the changes as a part of the other issue, I'm fine with it. |
Signed-off-by: Francesco Torchia <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary
Fixes #11236
Occurred changes and/or fixed issues
This PR enhances the
SelectOrCreateAuthSecret
component so that for the SSH secret type, it can also support theknown_hosts
field. Note that this is non-standard in that known hosts is not part of the standard k8s SSH secret type. This is only used by Fleet.The Fleet GitRepo use of the above control enables the new field, so that when creating a GitRepo, you can specify the known hosts information.
Lastly, the secret view is updated, so that if an SSH secret has the
known_hosts
data key, we will show this on the detail screen and also allow the user to edit via the config screen.Areas or cases that should be tested
Creating a Git Repo with a secret with known hosts. Validate that the secret that is created has the known_hosts data field and validate that this can be edited in the secrets screen.
Screenshot/Video
The updated auth secret control:
The edit dialog for this control when you click the three dots:
Secrets edit view when
known_hosts
is present in an SSH secret:EDIT @torchiaf
Screencast.from.2025-01-30.18-09-07.webm
Checklist