-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrated editing imported cluster to Vue #13216
Conversation
0ba5dd2
to
3a265be
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested imported and local rke2 and k3s clusters and everything seemed functional, keeping in mind the changes you highlighted in your demo (showing networking while cluster is pending; not showing PNI for rke2/k3s)
I noticed some options have changed for imported and local rke1 (generic?) clusters, but I also see some weird behavior in the Ember UI, so it's not clear to me how much of the differences are just you fixing existing bugs:
- In ember imported rke1 clusters in a 'pending' state have PNI and agent env var inputs that go away once the cluster is provisioned - is it a bug that they were shown at all?
- In ember imported/local rke1 clusters do not have authorized endpoint inputs...I don't see errors when configuring them with this PR but wasn't sure exposing them was intentional
- local rke1 cluster in ember has agent env var and PNI inputs. This form seems a little broken in general, though: by default I couldn't save and had to manually add an admin user
Aside from my rke1 confusion the PR generally looks good, I had only minor comments
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - reviewed updates with both k3s/rke2 and rke1 clusters
Summary
Fixes #9476 #10432
Migrated editing imported cluster to Vue.
Occurred changes and/or fixed issues
Technical notes summary
This PR only covers editing functionality. I will move creation over as part of #13151
Areas or cases that should be tested
Areas which could experience regressions
Screenshot/Video
Checklist