Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fleet: Add CLusters labels #13217

Merged
merged 2 commits into from
Jan 30, 2025
Merged

Conversation

torchiaf
Copy link
Member

@torchiaf torchiaf commented Jan 28, 2025

Summary

Fixes #11241

Occurred changes and/or fixed issues

Technical notes summary

  • Added labels subRow to Cluster List

Areas or cases that should be tested

Areas which could experience regressions

Screenshot/Video

image

Show more button

image

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

Signed-off-by: Francesco Torchia <[email protected]>
@torchiaf torchiaf force-pushed the 11241-clusters-labels branch from c3c2009 to d11320a Compare January 28, 2025 11:44
@torchiaf torchiaf requested a review from aalves08 January 28, 2025 11:45
@torchiaf torchiaf marked this pull request as ready for review January 28, 2025 11:45
@torchiaf torchiaf added this to the v2.11.0 milestone Jan 28, 2025
@torchiaf torchiaf changed the title 11241 clusters labels Fleet: Add CLusters labels Jan 29, 2025
Copy link
Member

@aalves08 aalves08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM mate 🙏

Screenshot 2025-01-29 at 10 39 54

@torchiaf torchiaf merged commit 94dfe01 into rancher:master Jan 30, 2025
66 of 85 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fleet Cluster Table: Show Cluster Labels
2 participants