Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing Workloads page title. #13219

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

torchiaf
Copy link
Member

@torchiaf torchiaf commented Jan 28, 2025

Summary

Occurred changes and/or fixed issues

Workloads page title is missing.

fixes #13197

Technical notes summary

Areas or cases that should be tested

  • Workloads nav, to verify Resource's titles of Workloads and other sub types (e.g.: Pods, Jobs, ....)

image

Areas which could experience regressions

Screenshot/Video

Before

image

After

image

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

Signed-off-by: Francesco Torchia <[email protected]>
@torchiaf torchiaf added this to the v2.11.0 milestone Jan 28, 2025
@torchiaf torchiaf changed the title Add workload typeDisplay Fix missing Workloads page title. Jan 28, 2025
Copy link
Member

@cnotv cnotv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems a regression of #11672

LGTM

@torchiaf torchiaf merged commit c987984 into rancher:master Jan 28, 2025
54 of 57 checks passed
@richard-cox
Copy link
Member

@torchiaf @cnotv The referenced issue was assigned to me and already had a PR up.

It also contained a useful comment to ensure no-one removed it in future. I'll update the original PR to include just that

@richard-cox richard-cox mentioned this pull request Jan 30, 2025
7 tasks
@cnotv
Copy link
Member

cnotv commented Jan 30, 2025

Sorry @richard-cox I have not seen your PR linked in the issue, we did not want to step over.
It was just needed for him to get it done and we did not know how to deal with it in your absence.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Title of workloads page is "?"
3 participants