-
Notifications
You must be signed in to change notification settings - Fork 268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wire in new status.condition property #13273
base: master
Are you sure you want to change the base?
Conversation
b33330d
to
16284f6
Compare
16284f6
to
9fcb8c3
Compare
Linking rancher/rancher#48993 |
// }, | ||
{ | ||
asc: false, | ||
field: 'status.connected' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The title of this pr seems to think we're supposed to be using status.condition
@@ -37,7 +37,7 @@ type ProvCluster = { | |||
} | |||
|
|||
/** | |||
* Order | |||
* Order of v1 mgmt clusters | |||
* 1. local cluster - https://github.com/rancher/dashboard/issues/10975 | |||
* 2. working clusters | |||
* 3. name |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The description of this pr also mentions something like:
- local cluster
- working clusters
- name
But judging from the issue I think 3. name
is supposed to read 3. everything else
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary
Fixes #13268
Occurred changes and/or fixed issues
Areas or cases that should be tested
Areas which could experience regressions
Checklist