Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jitter and resync to polling #3151

Merged
merged 3 commits into from
Jan 9, 2025
Merged

Add jitter and resync to polling #3151

merged 3 commits into from
Jan 9, 2025

Conversation

manno
Copy link
Member

@manno manno commented Dec 13, 2024

refers to #3138

  • Add jitter to the pollingInterval of GitRepos, jitter is plus minus 1/10 the polling interval
  • Gitops controller resyncs every hour, if gitrepos are lost from requeueAfter polling, resync should add them again.
  • Since the 10h cache sync is an update event, change predicates like GenerationChanged, prevent the reconcile from running.

@manno manno force-pushed the add-jitter-to-polling branch from 547cd2f to 777d5ac Compare December 16, 2024 17:29
@manno manno marked this pull request as ready for review December 18, 2024 09:34
@manno manno requested a review from a team as a code owner December 18, 2024 09:34
@manno manno force-pushed the add-jitter-to-polling branch from a7deeaf to a5a0d58 Compare December 18, 2024 16:03
@kkaempf kkaempf added this to the v2.10.2 milestone Dec 19, 2024
@manno manno force-pushed the add-jitter-to-polling branch 2 times, most recently from 098d0fb to 579060d Compare January 8, 2025 13:55
@manno manno force-pushed the add-jitter-to-polling branch 2 times, most recently from b0ece7b to 2dd28b7 Compare January 8, 2025 16:52
@manno manno changed the title Add jitter to polling Add jitter and resync to polling Jan 9, 2025
@manno manno force-pushed the add-jitter-to-polling branch from 2dd28b7 to 440d246 Compare January 9, 2025 14:05
@manno
Copy link
Member Author

manno commented Jan 9, 2025

/backport v2.10.2

@manno manno merged commit d9e8fd2 into main Jan 9, 2025
12 checks passed
@manno manno deleted the add-jitter-to-polling branch January 9, 2025 15:03
manno added a commit that referenced this pull request Jan 9, 2025
Don't poll all GitRepos at once, within ms.
If gitrepos are lost from the requeueAfter polling, resync should add them
again.

* Add jitter to the pollingInterval of GitRepos
* Gitops controller uses shorter resync interval
* GenerationChangedPredicate prevented Cache Sync to Trigger Reconciler
manno added a commit that referenced this pull request Jan 9, 2025
Don't poll all GitRepos at once, within ms.
If gitrepos are lost from the requeueAfter polling, resync should add them
again.

* Add jitter to the pollingInterval of GitRepos
* Gitops controller uses shorter resync interval
* GenerationChangedPredicate prevented Cache Sync to Trigger Reconciler
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants