Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add resourceCounts and incomplete state to BundleDeploymentStatus #3203

Merged
merged 10 commits into from
Jan 16, 2025

Conversation

aruiz14
Copy link
Contributor

@aruiz14 aruiz14 commented Jan 10, 2025

Refers to #3186

This PR extends the current public API to 2 new fields to every BundleDeploymentStatus:

  • incompleteState, which will be set to true if non-ready or modified resources status has more than 10 items.
  • resourceCounts, which counts the number of resources by their state.

The last commits add a small refactoring in order to make the code more testable, and add a unit test.

@aruiz14 aruiz14 requested a review from a team as a code owner January 10, 2025 15:07
@aruiz14 aruiz14 force-pushed the resourcecounts-in-bd-status branch 2 times, most recently from accb389 to de3c649 Compare January 10, 2025 15:23
@kkaempf kkaempf added this to the v2.11.0 milestone Jan 13, 2025
@kkaempf
Copy link
Collaborator

kkaempf commented Jan 13, 2025

Backport this to 2.10 ?

@aruiz14 aruiz14 force-pushed the resourcecounts-in-bd-status branch from c8dbc2b to b99db0f Compare January 15, 2025 12:39
@aruiz14 aruiz14 merged commit 0348ad2 into rancher:main Jan 16, 2025
12 checks passed
@aruiz14 aruiz14 deleted the resourcecounts-in-bd-status branch January 16, 2025 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants