Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve build process for VEXing #146

Merged
merged 6 commits into from
Jan 13, 2025

Conversation

mallardduck
Copy link
Member

@mallardduck mallardduck commented Jan 13, 2025

Before:

 → go version -m ./build/bin/prometheus-federator|head -2
./build/bin/prometheus-federator: go1.23.4
        path    command-line-arguments

After:

 → go version -m ./build/bin/prometheus-federator|head -2
./build/bin/prometheus-federator: go1.23.4
        path    github.com/rancher/prometheus-federator/cmd/prometheus-federator

Note that in the process of removing tags to improve VEX support we noticed that tags were also preventing some code from being linted. Specifically the cmd files were excluded. After the change they are included, so these additional commits to fix those changes were necessary.

@mallardduck mallardduck requested a review from a team as a code owner January 13, 2025 18:49
Per title, this scopes the test and validate scripts to the current build target.
The current behaviour with the tags actually fully excludes these which is why the errors (this commit fixes) don't exist with the tags in place.
@mallardduck mallardduck merged commit 0e2f8a1 into rancher:main Jan 13, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants