Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prerequisite for AKS import #1590

Merged
merged 4 commits into from
Jan 16, 2025

Conversation

yiannistri
Copy link
Contributor

Fixes rancher/aks-operator#743

Reminders

  • See the README for more details on how to work with the Rancher docs.

  • Verify if changes pertain to other versions of Rancher. If they do, finalize the edits on one version of the page, then apply the edits to the other versions.

  • If the pull request is dependent on an upcoming release, remember to add a "MERGE ON RELEASE" label and set the proper milestone.

Description

This PR adds a prerequisite as well as a troubleshooting section for importing AKS clusters.

Comments

Copy link
Contributor

@LucasSaintarbor LucasSaintarbor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yiannistri Made some small changes/suggestions. If these look okay, I'll apply the updates to v2.10/v2.9

mjura
mjura previously approved these changes Dec 24, 2024
furkatgofurov7
furkatgofurov7 previously approved these changes Jan 7, 2025
Copy link

@furkatgofurov7 furkatgofurov7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few suggestions

@yiannistri yiannistri force-pushed the update-aks-import-docs branch 4 times, most recently from acfbf6f to 395f249 Compare January 8, 2025 13:27
…her-setup/register-existing-clusters.md

Co-authored-by: Lucas Saintarbor <[email protected]>
@yiannistri yiannistri force-pushed the update-aks-import-docs branch from 395f249 to 4dd65ee Compare January 8, 2025 13:29
@yiannistri yiannistri dismissed stale reviews from furkatgofurov7 and mjura via e5176e0 January 8, 2025 14:26
@yiannistri
Copy link
Contributor Author

@LucasSaintarbor thanks for the review. Please take another look when you get a chance 🙏

@yiannistri
Copy link
Contributor Author

@LucasSaintarbor @btat @sunilarjun kind reminder to review this when possible 🙇

Copy link
Contributor

@LucasSaintarbor LucasSaintarbor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yiannistri LGTM, thanks!

@LucasSaintarbor LucasSaintarbor merged commit 7cc5f27 into rancher:main Jan 16, 2025
1 check passed
@yiannistri yiannistri deleted the update-aks-import-docs branch January 17, 2025 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add prerequisite for importing clusters in docs
5 participants