-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add prerequisite for AKS import #1590
Add prerequisite for AKS import #1590
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yiannistri Made some small changes/suggestions. If these look okay, I'll apply the updates to v2.10/v2.9
...to-guides/new-user-guides/kubernetes-clusters-in-rancher-setup/register-existing-clusters.md
Outdated
Show resolved
Hide resolved
...rence-guides/cluster-configuration/rancher-server-configuration/aks-cluster-configuration.md
Outdated
Show resolved
Hide resolved
...to-guides/new-user-guides/kubernetes-clusters-in-rancher-setup/register-existing-clusters.md
Outdated
Show resolved
Hide resolved
...to-guides/new-user-guides/kubernetes-clusters-in-rancher-setup/register-existing-clusters.md
Show resolved
Hide resolved
...to-guides/new-user-guides/kubernetes-clusters-in-rancher-setup/register-existing-clusters.md
Outdated
Show resolved
Hide resolved
...to-guides/new-user-guides/kubernetes-clusters-in-rancher-setup/register-existing-clusters.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few suggestions
...to-guides/new-user-guides/kubernetes-clusters-in-rancher-setup/register-existing-clusters.md
Outdated
Show resolved
Hide resolved
...to-guides/new-user-guides/kubernetes-clusters-in-rancher-setup/register-existing-clusters.md
Outdated
Show resolved
Hide resolved
...to-guides/new-user-guides/kubernetes-clusters-in-rancher-setup/register-existing-clusters.md
Outdated
Show resolved
Hide resolved
...to-guides/new-user-guides/kubernetes-clusters-in-rancher-setup/register-existing-clusters.md
Show resolved
Hide resolved
acfbf6f
to
395f249
Compare
…her-setup/register-existing-clusters.md Co-authored-by: Lucas Saintarbor <[email protected]>
395f249
to
4dd65ee
Compare
@LucasSaintarbor thanks for the review. Please take another look when you get a chance 🙏 |
@LucasSaintarbor @btat @sunilarjun kind reminder to review this when possible 🙇 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yiannistri LGTM, thanks!
Fixes rancher/aks-operator#743
Reminders
See the README for more details on how to work with the Rancher docs.
Verify if changes pertain to other versions of Rancher. If they do, finalize the edits on one version of the page, then apply the edits to the other versions.
If the pull request is dependent on an upcoming release, remember to add a "MERGE ON RELEASE" label and set the proper milestone.
Description
This PR adds a prerequisite as well as a troubleshooting section for importing AKS clusters.
Comments