#135 cluster id aws tagging #988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
btat
requested changes
Nov 17, 2023
...guides/new-user-guides/kubernetes-clusters-in-rancher-setup/set-up-cloud-providers/amazon.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Billy Tat <[email protected]>
btat
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #135
Reminders
See the README for more details on how to work with the Rancher docs.
Verify if changes pertain to other versions of Rancher. If they do, finalize the edits on one version of the page, then apply the edits to the other versions.
If the pull request is dependent on an upcoming release, make sure to target the release branch instead of
main.Description
This alters the language in the AWS doc to more clearly relate how to set the cluster ID string. There was some ambiguity, because we told users they could tag that value whatever they liked, as long as they were consistent. However, some nodes in an EC2 cluster would be automatically configured and users might manually tag resources something else entirely, resulting in confusion.
Comments
This is going to probably conflict with an open PR about out-of-tree AWS. We'll have to fix it there if that comes up.
The original issue points to the RKE docs, but the same error is present in our docs.