[Release-1.30] Add runtime classes hook and runtimes chart #7580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add runtime classes hook and runtimes chart Signed-off-by: Vitor Savian <[email protected]> * Addressing comments Signed-off-by: Vitor Savian <[email protected]> * Change const name to the same as helm upstream Signed-off-by: Vitor Savian <[email protected]> * Delete namespace const and use upstream namespace system Signed-off-by: Vitor Savian <[email protected]> --------- Signed-off-by: Vitor Savian <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-1.30 #7580 +/- ##
================================================
- Coverage 23.23% 22.94% -0.29%
================================================
Files 33 34 +1
Lines 3461 3504 +43
================================================
Hits 804 804
- Misses 2609 2652 +43
Partials 48 48
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
dereknola
approved these changes
Jan 13, 2025
VestigeJ
approved these changes
Jan 13, 2025
brandond
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport
Issue -> [Release-1.30] - RKE2 does not bundle RuntimeClass definitions #7575
PR -> Add runtime classes hook and runtimes chart #7382