Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove rancher-webhook feature from chart #1032

Merged

Conversation

salasberryfin
Copy link
Contributor

@salasberryfin salasberryfin commented Jan 22, 2025

What this PR does / why we need it:

Remove features.rancher-webhook and use rancherInstalled instead.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1025

Special notes for your reviewer:

**This cherry-picks

Checklist:

  • squashed commits into logical changes
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

@salasberryfin salasberryfin requested a review from a team as a code owner January 22, 2025 10:32
@salasberryfin salasberryfin added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. area/chart and removed kind/chore area/chart labels Jan 22, 2025
@salasberryfin salasberryfin changed the title WIP: remove rancher-webhook feature from chart chore: remove rancher-webhook feature from chart Jan 22, 2025
charts/rancher-turtles/questions.yml Outdated Show resolved Hide resolved
@salasberryfin salasberryfin force-pushed the chart-cleanup-more-features branch from eff4b8a to 30e5e8c Compare January 22, 2025 15:14
@salasberryfin salasberryfin requested a review from a team January 22, 2025 15:20
@Danil-Grigorev Danil-Grigorev enabled auto-merge (squash) January 23, 2025 09:04
@Danil-Grigorev Danil-Grigorev merged commit 2488cf7 into rancher:main Jan 23, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove features.embedded-capi and features.rancher-webhook
4 participants