Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Add unit tests for ClusterConfig #1038

Merged

Conversation

furkatgofurov7
Copy link
Contributor

What this PR does / why we need it:
Adds unit test for the deduplication feature implemented in #1011

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #761

Special notes for your reviewer:

Checklist:

  • squashed commits into logical changes
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

@furkatgofurov7 furkatgofurov7 requested a review from a team as a code owner January 23, 2025 12:34
@furkatgofurov7 furkatgofurov7 added area/testing Indicates an issue related to test kind/chore labels Jan 23, 2025
Signed-off-by: Furkat Gofurov <[email protected]>
@furkatgofurov7 furkatgofurov7 force-pushed the deduplication-unit-tests branch from 96ea1e2 to be23e4e Compare January 23, 2025 13:00
Copy link
Contributor

@Danil-Grigorev Danil-Grigorev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM

Copy link
Member

@alexander-demicev alexander-demicev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@alexander-demicev alexander-demicev merged commit 7a9618e into rancher:main Jan 23, 2025
9 checks passed
@furkatgofurov7 furkatgofurov7 deleted the deduplication-unit-tests branch January 24, 2025 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/testing Indicates an issue related to test kind/chore
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Support deduplication when using ClusterctlConfig
3 participants