Sender matches sender #66
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlsad3
force-pushed
the
sender-matches-sender
branch
from
ed1f155 to
ef5ad23
Compare
mlsad3
force-pushed
the
sender-matches-sender
branch
from
ef5ad23 to
83e7f29
Compare
Currently Sender only matches on 'from'. This resolves Issue ranmocy#35 by making Sender match: - reply_to - from - sender - X-Original-Sender This is similar to the functionality we have in `receiver`, which matches 'to', 'cc', 'bcc', and 'list'. We also speed up analysis by switching from getRawContent to getHeader.
mlsad3
force-pushed
the
sender-matches-sender
branch
from
83e7f29 to
4b31f5b
Compare
|
Hi @ranmocy , Any thoughts on this PR? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently Sender only matches on 'from'. This PR resolves #35 by making Sender match:
This is similar to the functionality we have in
receiver, which matches 'to', 'cc', 'bcc', and 'list'.We also speed up analysis by switching from getRawContent to getHeader.
NOTE: This utilizes @aaronj1335 's Utils PR (or I could not run anything).