Doing nothing is allowed #70
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlsad3
force-pushed
the
doing-nothing-is-allowed
branch
5 times, most recently
from
359507d to
08e0809
Compare
|
FWIW, I support this addition. Importantly, it is intuitive for new users. |
Rows in the rules sheet can match a mail, but do not need to specify actions. This is a different way of doing PR ranmocy#29, instead of adding a new InboxActionType we just decide to not worry about if a thread has any actions to do (as long as it matched a rule).
mlsad3
force-pushed
the
doing-nothing-is-allowed
branch
from
08e0809 to
4a01d2a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow rules with no actions.
Rows in the rules sheet can match a mail, but do not need to specify actions.
@aaronj1335 and @ranmocy, This is just a different way of doing PR #29 instead of adding a new InboxActionType. #29 has been around for a couple years and has valid reasons for merging, so this is just giving an alternative in case it helps speed things along ;)
Previously, Gmail Automata would Throw error if an email matched a rule but did nothing. This was a little counter-intuitive, since Gmail Automata did not throw any errors about the rule when parsing it.
This PR includes a prerequisite PR #65 (Cleanup imports/linting, Refactor tests). The main commit to look at (which has the logic for "Allowing rules with no actions") is 9640012.