Added gallery thumbnail count #624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…z/core into feature/gallery-thumbnail-counter
|
Can't we extract some of this somewhere else? Maybe a bit to much logic within the template. |
Roene-JustBetter
requested changes
Nov 1, 2024
Roene-JustBetter
previously approved these changes
Nov 1, 2024
JimmyHoenderdaal
previously approved these changes
Nov 5, 2024
Jade-GG
reviewed
Nov 5, 2024
royduin
reviewed
Nov 5, 2024
| @@ -0,0 +1,39 @@ | |||
| <div v-if="images.length > 1" class="flex mt-3 gap-2"> | |||
| <button | |||
| v-for="(image, imageId) in images.slice(0, {{ max(config('rapidez.frontend.product_gallery_thumbnails.xs'), config('rapidez.frontend.product_gallery_thumbnails.sm'), config('rapidez.frontend.product_gallery_thumbnails.md'), config('rapidez.frontend.product_gallery_thumbnails.lg'), config('rapidez.frontend.product_gallery_thumbnails.xl')) + 1 }})" | |||
There was a problem hiding this comment.
max(config('rapidez.frontend.product_gallery_thumbnails')) should be enough, but... I don't like the config for such a small part separated from the template. Maybe just define them on top of here?
@php($breakpoints = ['xl' => 7, 'lg' => 5, 'md' => 4, 'sm' => 3, 'xs' => 4])And use that here; max($breakpoints) and through the template
There was a problem hiding this comment.
But if we only want to change the breakpoints and everything else stays the same, then do we have to override this file in our project just to change breakpoints instead of changing it in the config file?
jordythevulder
dismissed stale reviews from JimmyHoenderdaal and Roene-JustBetter
via
03bd056
royduin
reviewed
Nov 6, 2024
3,
Outdated
There was a problem hiding this comment.
Removed those weird files!
…z/core into feature/gallery-thumbnail-counter
Jade-GG
reviewed
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will add a customizable thumbnail quantity.