Checkout frontend tweaks and resolved checkout header issue

[jordythevulder]

Small frontend tweaks.

Resolved checkout header issue where the "regular" checkout header is rendered when url had checkout/*

[royduin]

So what issue did you have with the header?

[jordythevulder]

So what issue did you have with the header?

Issue was:

• Cart had" regular header" (this is correct) with url /cart
• Checkout credentials had "checkout header" (this is correct) with url /checkout
• Checkout Payment had "regular header" (INCORRECT) with url /checkout/payment
• When navigating back to step credentials, also then credentials had "Regular header" (INCORRECT) with url /checkout/credentials

Had to change the is() function to the already existing routeIs() function

[royduin]

Ah I see, but routeIs() check the route name and is() checks the url. Not sure if that's tested everywhere? Maybe payment providers do add additional checkout/* routes?

All checkout steps do get the checkout name:

core/routes/web.php

Line 18 in c2a0bd7

Route::get('checkout/{step?}', config('rapidez.routing.controllers.checkout'))->middleware('auth:magento-cart')->name('checkout');

But the success page does have checkout.success as route name:

core/routes/web.php

Line 15 in c2a0bd7

Route::get('checkout/success', config('rapidez.routing.controllers.checkout-success'))->name('checkout.success');

Wildcards can also be used: https://laravel.com/docs/master/requests#inspecting-the-request-path