Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.x] Fix image urls #648

Merged
merged 3 commits into from
Nov 19, 2024
Merged

[2.x] Fix image urls #648

merged 3 commits into from
Nov 19, 2024

Conversation

BobWez98
Copy link
Collaborator

@BobWez98 BobWez98 commented Nov 18, 2024

There's no reason to use the resizedpath helper in places where it's not needed. It will only make the helper unnecessarily complex. The helper function is only needed when graphql returns store specific urls. Which is not the case on the POP, PDP and in product sliders.

V3: #649

@BobWez98 BobWez98 changed the title Fix image urls [2.x] Fix image urls Nov 18, 2024
@BobWez98 BobWez98 mentioned this pull request Nov 18, 2024
@royduin royduin merged commit 6d345d2 into 2.x Nov 19, 2024
15 checks passed
@royduin royduin deleted the feature/resized-path-2.x branch November 19, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants