Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Instantsearch] Scout indexing products & categories #734
[Instantsearch] Scout indexing products & categories #734
Changes from all commits
2274966
ecb1767
c223aa6
5631095
de8c0a7
0c6fa5b
9995245
9d11f76
1ed9fa7
a76853e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
This file was deleted.
This file was deleted.
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to infer this from the model itself? It would save us from setting this value which thanks to your changes doesn't seem needed anymore.
Perhaps a function that reads from an empty model variable/constant, which if it's not set Str::snake() on the class name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's also an option; currently we do this differently on multiple places, for example:
config.index
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had done this originally, but figured we might want to keep flexibility up for now, and it might not work properly if you overwrite a model with a different class name (e.g. if your code standards require you to call your extended version of a product model
ProductExt
or whatever).There's also the thing where it checks if you tried to use Scout directly. Although we'd probably be better off using a different solution for that eventually.