Make more constexpr available on device for cuIO #17746
Open
+259
−177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PointKernel
added
feature request
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
/ok to test |
PointKernel
commented
Jan 15, 2025
vuule
reviewed
Jan 24, 2025
| @@ -28,7 +28,7 @@ | |||
| namespace cudf::io::parquet::detail { | |||
|
|
|||
| struct page_state_s { | |||
| constexpr page_state_s() noexcept {} | |||
| CUDF_HOST_DEVICE constexpr page_state_s() noexcept {} | |||
There was a problem hiding this comment.
Pretty sure the struct is not intended for compile-time use. All uses I see are in shared memory.
Suggested change
| CUDF_HOST_DEVICE constexpr page_state_s() noexcept {} | |
| CUDF_HOST_DEVICE page_state_s() noexcept {} |
| @@ -105,15 +105,15 @@ struct delta_binary_decoder { | |||
|
|
|||
| // returns the value stored in the `value` array at index | |||
| // `rolling_index<delta_rolling_buf_size>(idx)`. If `idx` is `0`, then return `first_value`. | |||
| constexpr zigzag128_t value_at(size_type idx) | |||
| __device__ constexpr zigzag128_t value_at(size_type idx) | |||
There was a problem hiding this comment.
Suggested change
| __device__ constexpr zigzag128_t value_at(size_type idx) | |
| __device__ zigzag128_t value_at(size_type idx) |
| { | ||
| return idx == 0 ? first_value : value[rolling_index<delta_rolling_buf_size>(idx)]; | ||
| } | ||
|
|
||
| // returns the number of values encoded in the block data. when all_values is true, | ||
| // account for the first value in the header. otherwise just count the values encoded | ||
| // in the mini-block data. | ||
| constexpr uint32_t num_encoded_values(bool all_values) | ||
| __device__ constexpr uint32_t num_encoded_values(bool all_values) |
There was a problem hiding this comment.
Suggested change
| __device__ constexpr uint32_t num_encoded_values(bool all_values) | |
| __device__ uint32_t num_encoded_values(bool all_values) |
| @@ -41,6 +41,21 @@ namespace cudf { | |||
| namespace strings { | |||
| namespace detail { | |||
|
|
|||
| template <typename Iter> | |||
| struct string_offsets_fn { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Contributes to #7795
This PR addressed most of the relaxed constexpr in cuIO.
Checklist