Expose stream-ordering in scalar and avro APIs #17766
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
shrshi
added
improvement
| */ | ||
| explicit operator value_type() const; | ||
| T get_value(rmm::cuda_stream_view stream = cudf::get_default_stream()) const; |
There was a problem hiding this comment.
RMM just calls this value. We often try to avoid “get” in our function names.
| T get_value(rmm::cuda_stream_view stream = cudf::get_default_stream()) const; | |
| T value(rmm::cuda_stream_view stream = cudf::get_default_stream()) const; |
There was a problem hiding this comment.
Wait, doesn’t value already exist just below here? We may not need get_value at all. Maybe we just need to delete the conversion operator since it does not take a stream.
There was a problem hiding this comment.
Good point - I chose to introduce another function here because value can return either host or device data depending on the type. string_scalar::value returns a cudf::string_view on the device, while fixed_point::value and fixed_width::value copy to host. I was also unsure of using fixed_point::value directly since the conversion operator returns the fixed_point_value instead of the unscaled value.
There was a problem hiding this comment.
I'm hesitant to modify string_scalar::value to return a host string view since it is used in several places that directly access the scalar on device. One option is to rename this function to string_scalar::d_value and introduce another string_scalar::value that returns a std::string?
There was a problem hiding this comment.
The string_scalar::value() should return a cudf::string_view which is possible from host or device since it just wraps a pointer and a size held by the string_scalar. No device code is needed. Actually the stream parameter is not used at all.
To return a host std::string one would use the string_scalar::to_string() function.
There was a problem hiding this comment.
I agree with Bradley we should not have the get_value() functions and just keep the value() ones.
| */ | ||
| explicit operator value_type() const; | ||
| T get_value(rmm::cuda_stream_view stream = cudf::get_default_stream()) const; |
There was a problem hiding this comment.
Maybe we should delete this. There are already value and fixed_point_value functions.
| */ | ||
| explicit operator std::string() const; | ||
| std::string get_value(rmm::cuda_stream_view stream = cudf::get_default_stream()) const; |
| @@ -81,7 +81,7 @@ void ASSERT_BINOP(cudf::column_view const& out, | |||
| TypeOp&& op, | |||
| ValueComparator const& value_comparator = ValueComparator()) | |||
| { | |||
| auto lhs_h = static_cast<ScalarType const&>(lhs).operator TypeLhs(); | |||
| auto lhs_h = static_cast<ScalarType const&>(lhs).get_value(cudf::get_default_stream()); | |||
There was a problem hiding this comment.
Please refactor the tests like this:
| auto lhs_h = static_cast<ScalarType const&>(lhs).get_value(cudf::get_default_stream()); | |
| auto lhs_h = static_cast<ScalarType const&>(lhs).value(cudf::get_default_stream()); |
Description
Contributes to #13744
Replaces conversion operators in derived classes of
cudf::scalarwith stream-orderedget_value(stream)member function.Adds stream parameter to
cudf::io::read_avroChecklist