Fix count API issue about ignoring nan values
#17779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
galipremsagar
added
bug
galipremsagar
changed the title
count API issue about ignoring nan valuescount API issue about ignoring nan value
galipremsagar
changed the title
count API issue about ignoring nan valuecount API issue about ignoring nan values
mroeschke
reviewed
Jan 22, 2025
mroeschke
reviewed
Jan 23, 2025
mroeschke
approved these changes
Jan 23, 2025
|
/merge |
rapids-bot
bot
merged commit db7f1e3
into
rapidsai:branch-25.02
105 of 107 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes: #17768
This PR fixes the
countapi to match default dtype behavior wherenan's are not counted as valid elements. But retains countingnan's as valid in non-pandas compatibility modes because that is what pandas nullable dtypes do.Checklist