-
Notifications
You must be signed in to change notification settings - Fork 921
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run spark-rapids-jni CI #17781
base: branch-25.02
Are you sure you want to change the base?
Run spark-rapids-jni CI #17781
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI: If we plan to migrate this to pr.yaml
, we can add the same conditions we use for test_java
:
if: fromJSON(needs.changed-files.outputs.changed_file_groups).test_java
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
/ok to test |
/ok to test |
/ok to test |
/ok to test |
/ok to test |
/ok to test |
/ok to test |
This reverts commit 6625931.
spark-rapids-jni-build: | ||
runs-on: linux-amd64-cpu8 | ||
container: | ||
image: peixinl198/spark-rapids-jni:rockylinux8-cuda12.2.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you confirm this is a short term option until we get a more official docker location set up?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Absolutely. I'm waiting for the Spark team to get me a properly published image.
- name: "Build spark-rapids-jni" | ||
run: | | ||
mkdir target | ||
GPU_ARCHS=89-real LIBCUDF_DEPENDENCY_MODE=latest scl enable gcc-toolset-11 build/buildcpp.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How is 89-real being chosen? Our normal build targets RAPIDS (70;75;80;86;90). Should it not be one of these archs?
Checking target/buildcpp-env.sh that is the translation of the flags from Maven, the only discrepancy standing out is USE_GDS=ON
GPU_ARCHS=89-real LIBCUDF_DEPENDENCY_MODE=latest scl enable gcc-toolset-11 build/buildcpp.sh | |
GPU_ARCHS=90 LIBCUDF_DEPENDENCY_MODE=latest USE_GDS=ON scl enable gcc-toolset-11 build/buildcpp.sh |
Description
Run the CI for
spark-rapids-jni
to ensure that we don't break their build.Issue: #17337
Checklist