Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run spark-rapids-jni CI #17781

Open
wants to merge 14 commits into
base: branch-25.02
Choose a base branch
from

Conversation

KyleFromNVIDIA
Copy link
Contributor

Description

Run the CI for spark-rapids-jni to ensure that we don't break their build.

Issue: #17337

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@KyleFromNVIDIA KyleFromNVIDIA added the DO NOT MERGE Hold off on merging; see PR for details label Jan 22, 2025
@KyleFromNVIDIA KyleFromNVIDIA requested a review from a team as a code owner January 22, 2025 22:58
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI: If we plan to migrate this to pr.yaml, we can add the same conditions we use for test_java:

if: fromJSON(needs.changed-files.outputs.changed_file_groups).test_java

@KyleFromNVIDIA KyleFromNVIDIA marked this pull request as draft January 23, 2025 14:31
Copy link

copy-pr-bot bot commented Jan 23, 2025

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@KyleFromNVIDIA
Copy link
Contributor Author

/ok to test

@KyleFromNVIDIA
Copy link
Contributor Author

/ok to test

@KyleFromNVIDIA
Copy link
Contributor Author

/ok to test

@KyleFromNVIDIA
Copy link
Contributor Author

/ok to test

@KyleFromNVIDIA
Copy link
Contributor Author

/ok to test

@KyleFromNVIDIA
Copy link
Contributor Author

/ok to test

@KyleFromNVIDIA
Copy link
Contributor Author

/ok to test

@KyleFromNVIDIA KyleFromNVIDIA marked this pull request as ready for review January 23, 2025 15:30
@KyleFromNVIDIA KyleFromNVIDIA added 3 - Ready for Review Ready for review by team feature request New feature or request and removed DO NOT MERGE Hold off on merging; see PR for details labels Jan 23, 2025
@KyleFromNVIDIA KyleFromNVIDIA added the non-breaking Non-breaking change label Jan 23, 2025
@KyleFromNVIDIA KyleFromNVIDIA requested a review from a team as a code owner January 23, 2025 16:43
@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Jan 23, 2025
@github-actions github-actions bot removed the libcudf Affects libcudf (C++/CUDA) code. label Jan 23, 2025
@KyleFromNVIDIA KyleFromNVIDIA added the DO NOT MERGE Hold off on merging; see PR for details label Jan 23, 2025
spark-rapids-jni-build:
runs-on: linux-amd64-cpu8
container:
image: peixinl198/spark-rapids-jni:rockylinux8-cuda12.2.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you confirm this is a short term option until we get a more official docker location set up?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Absolutely. I'm waiting for the Spark team to get me a properly published image.

- name: "Build spark-rapids-jni"
run: |
mkdir target
GPU_ARCHS=89-real LIBCUDF_DEPENDENCY_MODE=latest scl enable gcc-toolset-11 build/buildcpp.sh
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How is 89-real being chosen? Our normal build targets RAPIDS (70;75;80;86;90). Should it not be one of these archs?

Checking target/buildcpp-env.sh that is the translation of the flags from Maven, the only discrepancy standing out is USE_GDS=ON

Suggested change
GPU_ARCHS=89-real LIBCUDF_DEPENDENCY_MODE=latest scl enable gcc-toolset-11 build/buildcpp.sh
GPU_ARCHS=90 LIBCUDF_DEPENDENCY_MODE=latest USE_GDS=ON scl enable gcc-toolset-11 build/buildcpp.sh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team DO NOT MERGE Hold off on merging; see PR for details feature request New feature or request non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants