Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in exception raised when attempting to convert a string column to cupy #17800

Merged
merged 11 commits into from
Jan 28, 2025
Merged

Fix typo in exception raised when attempting to convert a string column to cupy #17800

merged 11 commits into from
Jan 28, 2025

Conversation

dagardner-nv
Copy link
Contributor

@dagardner-nv dagardner-nv commented Jan 23, 2025 •
edited by galipremsagar
Loading

Description

Closes #17799

Fix typo in exception raised when attempting to convert a string column to cupy

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@dagardner-nv dagardner-nv requested a review from a team as a code owner January 23, 2025 21:00
@github-actions github-actions bot added the Python Affects Python cuDF API. label Jan 23, 2025
@galipremsagar
Copy link
Contributor

/okay to test

@galipremsagar galipremsagar added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jan 24, 2025
@galipremsagar
Copy link
Contributor

/merge

vyasr
vyasr previously requested changes Jan 24, 2025
View reviewed changes
python/cudf/cudf/core/column/string.py Outdated Show resolved Hide resolved
python/cudf/cudf/tests/test_dataframe.py Outdated Show resolved Hide resolved
@bdice @vyasr
Use TypeError
63339bc 
Co-authored-by: Vyas Ramasubramani <[email protected]>
@bdice bdice dismissed vyasr’s stale review January 25, 2025 00:05

Changes applied

@bdice
Copy link
Contributor

bdice commented Jan 25, 2025

/ok to test

@rapids-bot rapids-bot bot merged commit 39bcd16 into rapidsai:branch-25.02 Jan 28, 2025
107 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice left review comments

@vyasr vyasr vyasr left review comments

@galipremsagar galipremsagar galipremsagar approved these changes

@wence- wence- Awaiting requested review from wence- wence- is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@mroeschke mroeschke Awaiting requested review from mroeschke

Assignees

@vyasr vyasr

@bdice bdice

@mroeschke mroeschke

@galipremsagar galipremsagar

@dagardner-nv dagardner-nv

Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
cuDF Python
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Exception raised when attempting to call to_cupy on a string column has a typo
5 participants
@dagardner-nv @galipremsagar @bdice @vyasr @mroeschke