[REVIEW] fea/hash_index #1917
Closed
[REVIEW] fea/hash_index #1917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkraus14
reviewed
Jun 4, 2019
| # hash_columns produces negative valuesg | ||
| # probably can switch to np.uint32 | ||
| # when supported by libcud | ||
| return abs(sr) |
There was a problem hiding this comment.
Just to confirm, you want to return a Series here and not a subtype of Index?
There was a problem hiding this comment.
I think so -- i need to build some things in dask to properly check now
kkraus14
added
3 - Ready for Review
kkraus14
requested changes
Jun 4, 2019
kkraus14
reviewed
Jun 4, 2019
kkraus14
approved these changes
Jun 4, 2019
Co-Authored-By: Keith Kraus <[email protected]>
|
@quasiben I'm going to hold off on merging this until you give the go ahead that no more changes are needed to support dask. |
kkraus14
added
0 - Waiting on Author
|
@kkraus14, thanks. I think we should hold off as well |
|
I think #1720 may be blocking this PR. |
kkraus14
requested changes
Jun 4, 2019
|
Going to close this for now and we can reopen in the future if we want/need to. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds method to create a hash of the index. This is a first step for resolving failures in rapidsai/dask-cudf#262
cc @kkraus14