-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve parallelism of nightly wheel builds #1516
Conversation
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
/ok to test |
PUBLIC "$<BUILD_INTERFACE:${CUPROJ_SOURCE_DIR}/include>" | ||
PUBLIC "$<BUILD_INTERFACE:${CUPROJSHIM_SOURCE_DIR}/include>" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the only manual changes in this PR... fixes this finding from cmake-lint
:
python/cuproj/cuproj/cuprojshim/CMakeLists.txt:140,02: [E1122] Duplicate keyword argument PUBLIC
My read of https://cmake.org/cmake/help/latest/command/target_include_directories.html is that these forms of https://cmake.org/cmake/help/latest/command/target_include_directories.html are equivalent, so this is just a style thing and I don't think it should affect behavior at all.
libcuspatial
wheel builds, enforce cmake-format and cmake-lintlibcuspatial
wheel builds, enforce cmake-format and cmake-lint
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blocking for now on rapidsai/cugraph#4889 (review)
Yes, let's please split this up and do the CMake formatting/linting separately from the wheel build changes. |
will do |
libcuspatial
wheel builds, enforce cmake-format and cmake-lintlibcuspatial
wheel builds
libcuspatial
wheel builds
Removed all the style-related stuff. This now just contains the one small change to improve parallelism in nightly builds. |
This is blocked until #1517 is merged. |
all style-related stuff has been removed
@vyasr I just dismissed your blocking review, now that all the CMake formatting stuff has been totally removed and this PR just has the 1-line shared-workflows change. |
Thanks very much for updating this after merging #1517 @mroeschke ! |
/merge |
Description
Contributes to rapidsai/build-planning#136
Proposes the following:
wheel-build-cuspatial
depend onwheel-build-libcuspatial
in nightly CI, notwheel-publish-libcuspatial
wheel-build-cuspatial
just needslibcuspatial
wheels from S3, not nightly PyPINotes for Reviewers
Checklist