-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
avoid interactive prompts when updating from an environment.yaml #727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is blocked by #726 |
jameslamb
commented
Jan 31, 2025
context/test_notebooks.py
Outdated
@@ -31,6 +31,8 @@ | |||
# context on these being skipped: https://github.com/rapidsai/cuspatial/pull/1407 | |||
'cuspatial/cuspatial_api_examples.ipynb', | |||
'cuspatial/nyc_taxi_years_correlation.ipynb', | |||
# details: https://github.com/rapidsai/docker/issues/726 | |||
'cuspatial/trajectory_clustering.ipynb', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Proposing that we skip this notebook as well, to get CI working here.
The work of getting this working is described in #726.
Merged
bdice
approved these changes
Feb 3, 2025
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working with @taureandyernv yesterday, we tried something like this to patch in a dependency at run time.
Found that that prompts for confirmation:
But that prompt seems not to make it through to
mamba
.And even if that did work, this interactive prompt prevents the use of the "mount in an
environment.yml
" approach in situations where you aren't running the container interactively... for example, where you want to use this image in a container in a Kubernetes Pod, and provide anenvironment.yml
via a ConfigMap or file Secret.This proposes skipping the confirmation and always running
mamba env update -y
when anenvironment.yml
is provided.Notes for Reviewers
How I tested this
Pulled an image built from this PR and confirmed that that install pattern described above works and does not prompt for interactive input.