nx-cugraph: dispatch graph method to gpu or cpu #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to avoid unnecessary conversions to networkx data structures.
eriknw
added
improvement
rlratzel
approved these changes
Nov 19, 2024
| @@ -167,3 +167,31 @@ def _default_should_run(*args, **kwargs): | |||
|
|
|||
| def _restore_networkx_dispatched(name): | |||
| return getattr(BackendInterface, name) | |||
|
|
|||
|
|
|||
| def _gpu_cpu_api(nx_class, module_name): | |||
There was a problem hiding this comment.
Just a suggestion, feel free to ignore - I think I'd find these names a bit more self-documenting:
Suggested change
| def _gpu_cpu_api(nx_class, module_name): | |
| def create_method_dispatcher_factory(nx_class, module_name): |
which then gets called like:
create_method_dispatcher =
create_method_dispatcher_factory(...)
which then gets used like:
a = create_method_dispatcher("a")
...but I can also see how these feel like ctors and could be named with nouns.
There was a problem hiding this comment.
I cycled through a few names for these myself. The current @_gpu_cpu_api matches the style we already have with @networkx_api. Naming decorators can be descriptive, so I think they both read perfectly fine. If we were assigning the values to variables and not using decorators, then a factory-like name like your suggestion would probably be more appropriate.
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to avoid unnecessary conversions to networkx data structures.
Same as: rapidsai/cugraph#4749