Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set CCCL_TOPLEVEL_PROJECT to ON. #503

Closed
wants to merge 4 commits into from
Closed

Set CCCL_TOPLEVEL_PROJECT to ON. #503

wants to merge 4 commits into from

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Dec 11, 2023

Description

This helps fix some CCCL issues observed in rapidsai/rmm#1404.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.
  • The cmake-format.json is up to date with these changes.
  • I have added new files under rapids-cmake/
    • I have added include guards (include_guard(GLOBAL))
    • I have added the associated docs/ rst file and update the api.rst

@bdice bdice requested a review from a team as a code owner December 11, 2023 20:17
@bdice bdice self-assigned this Dec 11, 2023
@bdice bdice added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Dec 11, 2023
@bdice
Copy link
Contributor Author

bdice commented Dec 14, 2023

Closing. This was not the right fix. #505 correctly resolves the problem.

@bdice bdice closed this Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@bdice bdice

Labels
improvement Improves an existing functionality non-breaking Introduces a non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bdice