Skip to content

Commit

Permalink
Do some cleanup that is now supported by scikit-build-core
Browse files Browse the repository at this point in the history
  • Loading branch information
vyasr committed Jun 2, 2023
1 parent 2f74972 commit 43105dd
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 8 deletions.
2 changes: 0 additions & 2 deletions conda/recipes/rmm/meta.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,6 @@ build:

requirements:
build:
# TODO: See discussion in https://github.com/conda-forge/scikit-build-feedstock/issues/69,
# should cmake/ninja be in this section or in host?
- cmake >=3.23.1,!=3.25.0
- ninja
- {{ compiler('c') }}
Expand Down
7 changes: 1 addition & 6 deletions python/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -25,12 +25,7 @@ include(${CMAKE_BINARY_DIR}/RAPIDS.cmake)
project(
rmm-python
VERSION ${rmm_version}
# TODO: See if we can remove the C language when switching to scikit-build-core.
LANGUAGES # TODO: Building Python extension modules via the python_extension_module requires the C
# language to be enabled here. The test project that is built in scikit-build to verify
# various linking options for the python library is hardcoded to build with C, so until
# that is fixed we need to keep C.
C CXX)
LANGUAGES CXX)

option(FIND_RMM_CPP "Search for existing RMM C++ installations before defaulting to local files"
OFF)
Expand Down

0 comments on commit 43105dd

Please sign in to comment.