Skip to content

Commit

Permalink
Remove prefetch factory. (#1625)
Browse files Browse the repository at this point in the history
PR #1608 added a prefetch resource adaptor. However, per issue #1616, we want to remove the adaptor factories like `make_prefetch_adaptor` in favor of constructors with CTAD. I am removing the prefetch adaptor factory because it has not yet been released, and thus can be deleted without deprecation.

Authors:
  - Bradley Dice (https://github.com/bdice)

Approvers:
  - Vyas Ramasubramani (https://github.com/vyasr)
  - Rong Ou (https://github.com/rongou)
  - Mark Harris (https://github.com/harrism)

URL: #1625
  • Loading branch information
bdice authored Jul 25, 2024
1 parent e8df17d commit 8c20e14
Showing 1 changed file with 0 additions and 14 deletions.
14 changes: 0 additions & 14 deletions include/rmm/mr/device/prefetch_resource_adaptor.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -125,19 +125,5 @@ class prefetch_resource_adaptor final : public device_memory_resource {
Upstream* upstream_; // the upstream resource used for satisfying allocation requests
};

/**
* @brief Convenience factory to return a `prefetch_resource_adaptor` around the
* upstream resource `upstream`.
*
* @tparam Upstream Type of the upstream `device_memory_resource`.
* @param upstream Pointer to the upstream resource
* @return The new prefetch resource adaptor
*/
template <typename Upstream>
prefetch_resource_adaptor<Upstream> make_prefetch_adaptor(Upstream* upstream)
{
return prefetch_resource_adaptor<Upstream>{upstream};
}

/** @} */ // end of group
} // namespace rmm::mr

0 comments on commit 8c20e14

Please sign in to comment.