Skip to content

Commit

Permalink
Use rapids-cmake for the logger (#1776)
Browse files Browse the repository at this point in the history
This PR switches rmm to use rapids-cmake to fetch rapids-logger so that it uses a consistent version with the rest of RAPIDS to avoid any cases where transitive CPM loads result in multiple packages being built from source that require a different version of rapids-logger.

Depends on rapidsai/rapids-cmake#737

Contributes to rapidsai/build-planning#104.

Authors:
  - Vyas Ramasubramani (https://github.com/vyasr)

Approvers:
  - Bradley Dice (https://github.com/bdice)

URL: #1776
  • Loading branch information
vyasr authored Jan 3, 2025
1 parent 0a8e920 commit b4c43c5
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -73,9 +73,8 @@ rapids_find_package(
# add third party dependencies using CPM
rapids_cpm_init()

CPMAddPackage(
NAME rapids_logger GITHUB_REPOSITORY rapidsai/rapids-logger GIT_SHALLOW FALSE GIT_TAG
1043e0f3989d75ad52f5212544b8154777e86fc9 VERSION 1043e0f3989d75ad52f5212544b8154777e86fc9)
include(${rapids-cmake-dir}/cpm/rapids_logger.cmake)
rapids_cpm_rapids_logger()
rapids_make_logger(rmm EXPORT_SET rmm-exports)

include(cmake/thirdparty/get_cccl.cmake)
Expand Down

0 comments on commit b4c43c5

Please sign in to comment.