-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to using separate rapids-logger repo #1774
Merged
rapids-bot
merged 4 commits into
rapidsai:branch-25.02
from
vyasr:feat/use_rapids_logger
Jan 2, 2025
Merged
Switch to using separate rapids-logger repo #1774
rapids-bot
merged 4 commits into
rapidsai:branch-25.02
from
vyasr:feat/use_rapids_logger
Jan 2, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vyasr
added
non-breaking
Non-breaking change
improvement
Improvement / enhancement to an existing function
labels
Dec 30, 2024
vyasr
added
breaking
Breaking change
and removed
non-breaking
Non-breaking change
labels
Dec 31, 2024
bdice
reviewed
Jan 1, 2025
bdice
approved these changes
Jan 1, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving to unblock further work. I did not read the deleted code, just the CMake changes to use an external repo instead of the vendored code.
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes rmm's logger code in favor of using the rapids-logger repo to which that code was moved. The main material change is that with the latest commit on that repo rmm will dump output to stderr instead of to a file by default, which was the generally requested behavior and also aligns with the rest of RAPIDS's loggers pre-rapids-logger. Nonetheless, I've marked that as a breaking change (also because the rapids-logger code is no longer available from this repository).
Contributes to rapidsai/build-planning#104.
Checklist