Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add upper bound to prevent usage of numba 0.61.0 #1789

Merged
merged 4 commits into from
Jan 22, 2025

Conversation

galipremsagar
Copy link
Contributor

@galipremsagar galipremsagar commented Jan 22, 2025

Numba 0.61.0 just got released with a couple of breaking changes, this pr is required to unblock the ci.

xref: rapidsai/cudf#17777

Copy link

copy-pr-bot bot commented Jan 22, 2025

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@galipremsagar galipremsagar added non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels Jan 22, 2025
@github-actions github-actions bot added Python Related to RMM Python API conda labels Jan 22, 2025
@galipremsagar galipremsagar marked this pull request as ready for review January 22, 2025 02:58
@galipremsagar galipremsagar requested a review from a team as a code owner January 22, 2025 02:58
@vyasr
Copy link
Contributor

vyasr commented Jan 22, 2025

Was raising the numba floor intentional? We are still testing numba 0.57 in the "oldest" dependency set. Should that be bumped up, or do we want to retain 0.57 as a floor but increase the ceiling? Is the 0.59 floor here to match numba-cuda's requirement? If so, then we should just bump the oldest.

dependencies.yaml Outdated Show resolved Hide resolved
@galipremsagar
Copy link
Contributor Author

Was raising the numba floor intentional? We are still testing numba 0.57 in the "oldest" dependency set. Should that be bumped up, or do we want to retain 0.57 as a floor but increase the ceiling? Is the 0.59 floor here to match numba-cuda's requirement? If so, then we should just bump the oldest.

Thanks for catching this @vyasr ! Updated the oldest dependency set.

@galipremsagar
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 67fd94d into rapidsai:branch-25.02 Jan 22, 2025
62 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conda improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Related to RMM Python API
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants